Implement minikube image load command #10366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
medyagh
requested changes
Feb 5, 2021
pkg/minikube/machine/cache_images.go
Outdated
| @@ -61,6 +62,57 @@ func CacheImagesForBootstrapper(imageRepository string, version string, clusterB | |||
| return nil | |||
| } | |||
|
|
|||
| // LoadImage loads the local image into the container runtime | |||
| func LoadImage(profile, img string) error { | |||
There was a problem hiding this comment.
how about we make this a re-usable function that Cache Add also uses same, so we don't have to maintain both Image Load and Cache Add ?
I suggest adding a --all label to "cache add" command so if that is passed it will load image to all clusters if not, it will add it to the active cluster.
Image Load should be an alias of "Cache Add"
in a way that if user says
mnikube imge load alpne --all it will load the image to all clusters
and if not it will load it to current cluster.
|
kvm2 Driver Times for Minikube (PR 10366): 30.2s 27.7s 24.5s Averages Time Per Log |
afbjorklund
reviewed
Feb 5, 2021
added 5 commits
February 5, 2021 10:24
|
kvm2 Driver Times for Minikube (PR 10366): 65.2s 65.5s 66.2s Averages Time Per Log docker Driver Times for Minikube (PR 10366): 24.9s 24.5s 25.5s Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 10366): 66.0s 66.3s 67.3s Averages Time Per Log docker Driver Times for Minikube (PR 10366): 26.2s 26.3s 25.2s Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 10366): 67.6s 64.7s 66.4s Averages Time Per Log docker Driver Times for Minikube (PR 10366): 24.2s 22.8s 24.0s Averages Time Per Log |
medyagh
approved these changes
Feb 9, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
kvm2 Driver Times for Minikube (PR 10366): 68.8s 67.2s 65.8s Averages Time Per Log docker Driver Times for Minikube (PR 10366): 25.7s 27.4s 25.9s Averages Time Per Log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add an integration test for it.
closes #10365